Skip to content

[omdb] refactor attached_subnet_manager status into a Display and snapshot it - #11552

Merged
sunshowers merged 4 commits into
sunshowers/spr/meta-auto-replace-iddqd-in-sled-agent-clientfrom
sunshowers/spr/omdb-refactor-attached_subnet_manager-status-into-a-display-and-snapshot-it
Oct 22, 2026
Merged

sunshowers merged 4 commits into
sunshowers/spr/meta-auto-replace-iddqd-in-sled-agent-clientfrom
sunshowers/spr/omdb-refactor-attached_subnet_manager-status-into-a-display-and-snapshot-it

Conversation

@sunshowers

Copy link
Copy Markdown
Contributor

A small functional change in this commit -- the output no longer depends on HashMap order. (Can we change this into a BTreeMap or IdOrdMap in the future?)

@sunshowers
sunshowers changed the base branch from sunshowers/spr/main.omdb-refactor-attached_subnet_manager-status-into-a-display-and-snapshot-it to sunshowers/spr/meta-auto-replace-iddqd-in-sled-agent-client October 22, 2026 03:00
@sunshowers
sunshowers added this pull request to stack #11554 October 22, 2026 03:00
Comment on lines +2507 to +2508
// Sort the data by switch slot to ensure stable output.
let mut dendrite: Vec<_> = dendrite.iter().collect();

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the small change.

@sunshowers
sunshowers merged commit 962bff8 into main Oct 22, 2026
19 checks passed
@sunshowers
sunshowers deleted the sunshowers/spr/omdb-refactor-attached_subnet_manager-status-into-a-display-and-snapshot-it branch October 22, 2026 21:04
sunshowers added a commit that referenced this pull request Oct 22, 2026
#11553)

Followup from #11551 and #11552 -- previously, errors (duplicates or
otherwise) would not be displayed in omdb's output. Now they are, and we
destructure the struct exhaustively to ensure that if new fields are
added, those are also displayed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants